Skip to content

[deps] BRE: Update YamlDotNet to v16 #4665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
renovate wants to merge 4 commits into
base: main
Choose a base branch
from
+22 −6
Open

[deps] BRE: Update YamlDotNet to v16 #4665

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bc97541
[deps] BRE: Update YamlDotNet to v16
renovate[bot] Aug 24, 2025
4f24c84
Merge branch 'main' into renovate/yamldotnet-16.x
AmyLGalles Oct 8, 2025
a5c964b
fix: comment serialization in v16
coroiu Oct 13, 2025
da940ec
Merge branch 'main' into renovate/yamldotnet-16.x
AmyLGalles Dec 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion util/Setup/Setup.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
<ItemGroup>
<PackageReference Include="Handlebars.Net" Version="2.1.6" />
<PackageReference Include="Microsoft.Extensions.Logging" Version="8.0.1" />
<PackageReference Include="YamlDotNet" Version="11.2.1" />
<PackageReference Include="YamlDotNet" Version="16.3.0" />
</ItemGroup>

<ItemGroup>
Expand Down
26 changes: 21 additions & 5 deletions util/Setup/YamlComments.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,16 @@ public CommentGatheringTypeInspector(ITypeInspector innerTypeDescriptor)
_innerTypeDescriptor = innerTypeDescriptor ?? throw new ArgumentNullException(nameof(innerTypeDescriptor));
}

public override string GetEnumName(Type enumType, string name)
{
return _innerTypeDescriptor.GetEnumName(enumType, name);
}

public override string GetEnumValue(object enumValue)
{
return _innerTypeDescriptor.GetEnumValue(enumValue);
}

public override IEnumerable<IPropertyDescriptor> GetProperties(Type type, object container)
{
return _innerTypeDescriptor.GetProperties(type, container).Select(d => new CommentsPropertyDescriptor(d));
Expand All @@ -33,13 +43,19 @@ private sealed class CommentsPropertyDescriptor : IPropertyDescriptor
public CommentsPropertyDescriptor(IPropertyDescriptor baseDescriptor)
{
_baseDescriptor = baseDescriptor;
Name = baseDescriptor.Name;
}

public string Name { get; set; }
public int Order { get; set; }
public string Name => _baseDescriptor.Name;
public int Order
{
get => _baseDescriptor.Order;
set => _baseDescriptor.Order = value;
}
public Type Type => _baseDescriptor.Type;
public bool CanWrite => _baseDescriptor.CanWrite;
public bool AllowNulls => _baseDescriptor.AllowNulls;
public bool Required => _baseDescriptor.Required;
public Type ConverterType => _baseDescriptor.ConverterType;

public Type TypeOverride
{
Expand Down Expand Up @@ -95,7 +111,7 @@ public class CommentsObjectGraphVisitor : ChainedObjectGraphVisitor
public CommentsObjectGraphVisitor(IObjectGraphVisitor<IEmitter> nextVisitor)
: base(nextVisitor) { }

public override bool EnterMapping(IPropertyDescriptor key, IObjectDescriptor value, IEmitter context)
public override bool EnterMapping(IPropertyDescriptor key, IObjectDescriptor value, IEmitter context, ObjectSerializer serializer)
{
if (value is CommentsObjectDescriptor commentsDescriptor && commentsDescriptor.Comment != null)
{
Expand All @@ -105,6 +121,6 @@ public override bool EnterMapping(IPropertyDescriptor key, IObjectDescriptor val
context.Emit(new Comment(comment, false));
}
}
return base.EnterMapping(key, value, context);
return base.EnterMapping(key, value, context, serializer);
}
}
Loading