Skip to content

Conversation

@mzieniukbw
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-26585

📔 Objective

Remove SDK’s InitUserCryptoMethod::Password.
Remove InternalClient’s function initialize_user_crypto_master_key, rename to initialize_user_crypto_key_connector_key.

Moved existing usages (mostly testing) to InitUserCryptoMethod::MasterPasswordUnlock or initialize_user_crypto_master_password_unlock.

🚨 Breaking Changes

None expected.
Mobile already migrated off InitUserCryptoMethod::Password.
Client's WASM uses InitUserCryptoMethod::DecryptedKey (just so it can pass decrypted user key)

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@mzieniukbw mzieniukbw requested review from a team as code owners December 21, 2025 22:11
@mzieniukbw mzieniukbw changed the title [PM-26585] Remove InitUserCryptoMethod::Password [PM-26585] Remove InitUserCryptoMethod::Password in favour of InitUserCryptoMethod::MasterPasswordUnlock Dec 21, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 21, 2025

Logo
Checkmarx One – Scan Summary & Detailsb2d66413-bef3-4441-8c22-c20af70576d8

Great job! No new security vulnerabilities introduced in this pull request

@github-actions
Copy link
Contributor

github-actions bot commented Dec 21, 2025

🔍 SDK Breaking Change Detection Results

SDK Version: km/pm-26585-initusercryptomethod-password (2fb654c)
Completed: 2025-12-21 22:54:22 UTC
Total Time: 219s

Client Status Details
typescript ✅ No breaking changes detected TypeScript compilation passed with new SDK version - View Details

Breaking change detection completed. View SDK workflow

@codecov
Copy link

codecov bot commented Dec 21, 2025

Codecov Report

❌ Patch coverage is 89.54248% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.83%. Comparing base (b9cf7b7) to head (2fb654c).

Files with missing lines Patch % Lines
crates/bitwarden-core/src/client/test_accounts.rs 46.15% 14 Missing ⚠️
crates/bitwarden-core/src/client/internal.rs 0.00% 1 Missing ⚠️
crates/bitwarden-core/src/key_management/crypto.rs 98.46% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #629      +/-   ##
==========================================
- Coverage   78.84%   78.83%   -0.01%     
==========================================
  Files         283      283              
  Lines       29660    29718      +58     
==========================================
+ Hits        23384    23429      +45     
- Misses       6276     6289      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants