[PM-29048] Validate pin protected user key envelope #628
+117
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzieniukbw
requested review from
a team and
quexten
and removed request for
a team
Contributor
|
Great job! No new security vulnerabilities introduced in this pull request |
Contributor
🔍 SDK Breaking Change Detection ResultsSDK Version:
Breaking change detection completed. View SDK workflow |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #628 +/- ##
=======================================
Coverage 78.84% 78.84%
=======================================
Files 283 283
Lines 29660 29723 +63
=======================================
+ Hits 23384 23434 +50
- Misses 6276 6289 +13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
quexten
previously approved these changes
Dec 22, 2025
Contributor
quexten
left a comment
quexten
left a comment
There was a problem hiding this comment.
Some nits on the commenting, but nothing blocking.
quexten
approved these changes
Dec 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-29048
📔 Objective
Enables validation for a PIN for a pin protected key envelope, so that mobile can move off of
validatePinwhich only works with pin key protected userkeys.The original
validate_pinimplementation compared the decrypted user key from envelope with the client key stored user key. This implementation is much simpler, we simply validate if the envelope can be successfully unsealed with provided PIN.Tested against android.
🚨 Breaking Changes
None
⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes