Conversation
Bitwarden Claude Code ReviewOverall Assessment: APPROVE This PR adds an "Authoring Maps → Major Version Bumps" section to the root README documenting the cross-Map workflow for shipping a new major schema alongside the previous one, consolidates the Forms Map field key reference into a single combined table with clarifying prose on role/input semantics, and adds two fail-fast build invariants in Code Review DetailsNo findings. |
bensbits91
left a comment
There was a problem hiding this comment.
One minor issue with readme TOC after changing headings. Looks good otherwise
| Note, a field described by the `username` key is not exclusive to | ||
| authentication concerns, and may be represented in other form categories. | ||
|
|
||
| #### Names |
There was a problem hiding this comment.
TOC needs to be updated to fix broken links after changing headings. In the TOC, around lines 40-42
Old:
- [Name](#name)
- [Contact](#contact)
- [Address](#address)New:
- [Names](#names)
- [Contacts](#contacts)
- [Addresses](#addresses)
🎟️ Tracking
PM-37940
📔 Objective
Update guidance on field keys and authoring map major version changes
Additional context:
#18 (comment)
#11 (comment)