[PM-22159] ci: Add automated PR labelling based on file paths and title patterns#2225
[PM-22159] ci: Add automated PR labelling based on file paths and title patterns#2225
Conversation
|
Great job! No new security vulnerabilities introduced in this pull request |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2225 +/- ##
==========================================
- Coverage 85.47% 84.27% -1.20%
==========================================
Files 1746 1989 +243
Lines 147479 163714 +16235
==========================================
+ Hits 126055 137973 +11918
- Misses 21424 25741 +4317 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Claude finished @vvolkgang's task in 4m 26s —— View job Overall Assessment: APPROVE ✅ This PR adds automated PR labeling based on file paths and title patterns, implementing a Python script with GitHub Actions workflow. The implementation follows established patterns from the Android repository with appropriate adaptations for the iOS codebase structure. Code Review DetailsSecurity:
Correctness:
Configuration:
Maintainability:
No findings to report. Test Recommendations:
Clean implementation that maintains consistency with the Android repository while properly adapting to iOS codebase structure. Ready to merge after testing. |
| "t:feature-tool": [ | ||
| "TestHarness/", | ||
| "TestHarnessShared/", | ||
| "project-bwth.yml" |
There was a problem hiding this comment.
🤔 Should this include swiftgen-bwth.yml as well?
| "GlobalTestHelpers-bwa/", | ||
| "GlobalTestHelpers-bwth/", | ||
| "Sourcery/", | ||
| "TestHelpers/", |
There was a problem hiding this comment.
🤔 If we're including test helpers here, should we also include all the tests?
There was a problem hiding this comment.
Wasn't sure about it honestly, just wanted to assign most of the top level folders and files to something as a starting point and we can fine-tune later.

🎟️ Tracking
PM-22159
📔 Objective
Note
Mostly a copypaste from bitwarden/android#6157 with the exception of
label-pr.jsonAutomate pull request labelling based on changed file paths and PR title patterns following conventional commits format, as a first step towards release notes with automated ✨ categories ✨ !
.github/label-pr.json- planned using yaml initially but it would require an external dependency, introducing the need for python environment and dependency management. Python supports json deserialization out of the box. File based config will allow us to centralise these scripts in our gh-actions repo later down the line.Labels
App Labels (from file paths):
app:password-manager- Password manager app changesapp:authenticator- Authenticator app changesChange Type Labels:
t:feature-app- Addition or improvement of Product featurest:feature-tool- Addition or improvement of Tool features (e.g. Test Harness)t:bug- Bug fixest:tech-debt- Technical debt, refactoring, cleanupt:docs- Documentation changest:ci- CI/CD changest:deps- Dependency updatest:breaking-change- Breaking changest:misc- Miscellaneous (catch-all)⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes