Skip to content

[PM-29835] Add org events for item migration #2214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrebispo5 merged 1 commit into from
Jan 12, 2026
Merged

[PM-29835] Add org events for item migration #2214

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions BitwardenShared/Core/Platform/Models/Enum/EventType.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,4 +46,7 @@ public enum EventType: Int, Codable, Sendable {
case organizationUpdated = 1600
case organizationPurgedVault = 1601
case organizationClientExportedVault = 1602

case organizationItemOrganizationAccepted = 1618
case organizationItemOrganizationDeclined = 1619
Comment on lines +50 to +51
Copy link

Copilot AI Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The case names contain redundant "Organization" repetition. Following the existing naming patterns in this enum (e.g., organizationUserInvited, organizationUpdated, organizationPurgedVault), these should be named organizationItemAccepted and organizationItemDeclined instead of organizationItemOrganizationAccepted and organizationItemOrganizationDeclined. The extra "Organization" in the middle makes the names unnecessarily verbose and inconsistent with the established conventions.

Suggested change
case organizationItemOrganizationAccepted = 1618
case organizationItemOrganizationDeclined = 1619
case organizationItemAccepted = 1618
case organizationItemDeclined = 1619

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Contributor Author

@andrebispo5 andrebispo5 Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The naming is following the server name convention for consistency.

}