This repository was archived by the owner on Mar 6, 2025. It is now read-only.
generated from bitwarden/template
-
Notifications
You must be signed in to change notification settings - Fork 33
[PM-16534] Update output filenames #335
Merged
SaintPatrck
merged 25 commits into
main
from
repo-migration/consistent-output-filenames
Feb 12, 2025
+79
โ6
Merged
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
2dde87d
Rename app package to authenticator
SaintPatrck 0dad6f2
Workflows: renamed with -bwa prefix
vvolkgang 49a2eab
Fastlane: Add -bwa prefix and set check lane Gradle project
vvolkgang 71985cd
Revert "Workflows: renamed with -bwa prefix"
vvolkgang 9bf6635
Revert "Fastlane: Add -bwa prefix and set check lane Gradle project"
vvolkgang b95f528
Revert "Revert "Fastlane: Add -bwa prefix and set check lane Gradle pโฆ
vvolkgang fc6e987
Remove project from gradle task
vvolkgang 3e185cb
Rename suffix
vvolkgang 47cfe8d
Rename CI workflows for Authenticator
SaintPatrck a53f0f8
Rename Fastfile lanes to be Authenticator-specific
SaintPatrck 2388f49
Update output filenames
SaintPatrck 4a2cbf1
Replaced `check-bwa` with `checkAuthenticator` in workflow
SaintPatrck 785e089
Revert renaming of `check` lane
SaintPatrck c064f52
Missed some renaming....
SaintPatrck d75f962
Merge branch 'repo-migration/rename-app-module' into repo-migration/rโฆ
SaintPatrck 8b99d46
Merge branch 'repo-migration/rename-workflow-files' into repo-migratiโฆ
SaintPatrck a3ad3ce
Merge branch 'repo-migration/update-fastfile' into repo-migration/conโฆ
SaintPatrck 4a22c8f
Revert build.yml / Fastfile changes
vvolkgang 4ce2680
Merge remote-tracking branch 'origin/main' into repo-migration/renameโฆ
SaintPatrck a58836f
Revert workflow name changes
vvolkgang b34693a
Merge branch 'repo-migration/rename-app-module' into repo-migration/uโฆ
vvolkgang 7af9604
Merge branch 'repo-migration/update-fastfile' into repo-migration/conโฆ
vvolkgang d1811d3
Merge branch 'repo-migration/rename-app-module' into repo-migration/uโฆ
vvolkgang 5b65155
Merge branch 'repo-migration/update-fastfile' into repo-migration/conโฆ
vvolkgang 9e537cc
Merge branch 'main' into repo-migration/consistent-output-filenames
vvolkgang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| { | ||
| "project_info": { | ||
| "project_number": "867301491091", | ||
| "project_id": "bitwarden-authenticator", | ||
| "storage_bucket": "bitwarden-authenticator.firebasestorage.app" | ||
| }, | ||
| "client": [ | ||
| { | ||
| "client_info": { | ||
| "mobilesdk_app_id": "1:867301491091:android:3ee369dedcd20f6551e866", | ||
| "android_client_info": { | ||
| "package_name": "com.bitwarden.authenticator.dev" | ||
| } | ||
| }, | ||
| "oauth_client": [], | ||
| "api_key": [ | ||
| { | ||
| "current_key": "AIzaSyDDXnnBuWzuh8rlihiMWRPif_sqkGk3fxw" | ||
| } | ||
| ], | ||
| "services": { | ||
| "appinvite_service": { | ||
| "other_platform_oauth_client": [] | ||
| } | ||
| } | ||
| } | ||
| ], | ||
| "configuration_version": "1" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With this package name change, do we know if the sync feature will still function properly with the dev builds.
I am unsure if they look for specific package names or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see anything in Bitwarden that's looking for Authenticator's appId. Authenticator is what needs knowledge of the correct Bitwarden appId to query for.