This repository was archived by the owner on Mar 6, 2025. It is now read-only.
[PM-16534] Rename Fastfile lanes to be Authenticator-specific#334
Merged
SaintPatrck merged 21 commits intomainfrom Feb 12, 2025
Merged
[PM-16534] Rename Fastfile lanes to be Authenticator-specific#334SaintPatrck merged 21 commits intomainfrom
SaintPatrck merged 21 commits intomainfrom
Conversation
This reverts commit 0dad6f2.
This reverts commit 49a2eab.
…roject"" This reverts commit 9bf6635.
Rename workflows by appending `_authenticator` to their names.
Renamed the following lanes in the Fastfile to be more specific to the Authenticator module: - `check` to `checkAuthenticator` - `setBuildVersionInfo` to `setAuthenticatorBuildVersionInfo` - `buildDebug` to `buildAuthenticatorDebug` - `buildRelease` to `buildAuthenticatorRelease` - `bundleRelease` to `bundleAuthenticatorRelease` - `distributeReleaseBundleToFirebase` to `distributeAuthenticatorReleaseBundleToFirebase` - `publishReleaseToGooglePlayStore` to `publishAuthenticatorReleaseToGooglePlayStore` Updated the GitHub workflows to use the new lane names. Removed unused `json_key_file` and `package_name` from Appfile. Added `json_key` parameter to `validate_play_store_json_key` lane in `build_authenticator.yml` workflow. Added `package_name` parameter to `publishAuthenticatorReleaseToGooglePlayStore` lane in `build_authenticator.yml` workflow.
SaintPatrck
requested review from
a team,
brian-livefront,
david-livefront and
phil-livefront
as code owners
Contributor
|
Great job, no security vulnerabilities found in this Pull Request |
…ename-workflow-files
…on/update-fastfile # Conflicts: # .github/workflows/test_authenticator.yml # fastlane/Fastfile
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #334 +/- ##
=======================================
Coverage 44.69% 44.69%
=======================================
Files 119 119
Lines 5717 5717
Branches 684 684
=======================================
Hits 2555 2555
Misses 2981 2981
Partials 181 181 ☔ View full report in Codecov by Sentry. |
david-livefront
previously approved these changes
Feb 7, 2025
vvolkgang
changed the base branch from
repo-migration/rename-workflow-files
to
repo-migration/rename-app-module
vvolkgang
approved these changes
Feb 12, 2025
…pdate-fastfile # Conflicts: # .github/workflows/build.yml # fastlane/Fastfile
vvolkgang
previously approved these changes
Feb 12, 2025
vvolkgang
dismissed stale reviews from david-livefront and themself
The base branch was changed.
vvolkgang
approved these changes
Feb 12, 2025
vvolkgang
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
--
📔 Objective
Renamed the following lanes in the Fastfile to be more specific to the Authenticator module:
checktocheckAuthenticatorsetBuildVersionInfotosetAuthenticatorBuildVersionInfobuildDebugtobuildAuthenticatorDebugbuildReleasetobuildAuthenticatorReleasebundleReleasetobundleAuthenticatorReleasedistributeReleaseBundleToFirebasetodistributeAuthenticatorReleaseBundleToFirebasepublishReleaseToGooglePlayStoretopublishAuthenticatorReleaseToGooglePlayStoreUpdated the GitHub workflows to use the new lane names.
Removed unused
json_key_fileandpackage_namefrom Appfile.Added
json_keyparameter tovalidate_play_store_json_keylane inbuild_authenticator.ymlworkflow.Added
package_nameparameter topublishAuthenticatorReleaseToGooglePlayStorelane inbuild_authenticator.ymlworkflow.📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes