Remove remember ViewModel

[david-livefront]

🎟️ Tracking

N/A

📔 Objective

This PR removes all the instances of remeber(viewModel) from the click listeners in the codebase. These extra remebers are no longer needed since strong skipping will handle this for us. This will simplify a lot of our UIs.

[github-actions]

Checkmarx One – Scan Summary & Details – 8b867d2a-857c-47f6-b335-f880b1b3e281

Great job! No new security vulnerabilities introduced in this pull request

[codecov]

Codecov Report

❌ Patch coverage is 82.92683% with 126 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.54%. Comparing base (aa23d5e) to head (8b47245).
⚠️ Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
...n/ui/auth/feature/environment/EnvironmentScreen.kt	61.76%	13 Missing ⚠️
...tor/ui/platform/feature/settings/SettingsScreen.kt	72.97%	10 Missing ⚠️
...untconfirmation/DeleteAccountConfirmationScreen.kt	36.36%	1 Missing and 6 partials ⚠️
...i/platform/feature/settings/export/ExportScreen.kt	0.00%	7 Missing ⚠️
...den/ui/vault/feature/addedit/VaultAddEditScreen.kt	85.00%	6 Missing ⚠️
...form/feature/settings/importing/ImportingScreen.kt	0.00%	6 Missing ⚠️
.../settings/accountsecurity/AccountSecurityScreen.kt	86.84%	1 Missing and 4 partials ⚠️
...ings/autofill/blockautofill/BlockAutoFillScreen.kt	58.33%	0 Missing and 5 partials ⚠️
...en/ui/vault/feature/qrcodescan/QrCodeScanScreen.kt	28.57%	3 Missing and 2 partials ⚠️
...bitwarden/ui/auth/feature/landing/LandingScreen.kt	78.94%	0 Missing and 4 partials ⚠️
... and 28 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6618      +/-   ##
==========================================
- Coverage   85.90%   85.54%   -0.36%     
==========================================
  Files         804      973     +169     
  Lines       57370    59933    +2563     
  Branches     8307     8411     +104     
==========================================
+ Hits        49284    51271    +1987     
- Misses       5203     5744     +541     
- Partials     2883     2918      +35     

Flag	Coverage Δ
app-data	18.29% <0.00%> (+0.76%)	⬆️
app-ui-auth-tools	21.00% <29.98%> (+0.12%)	⬆️
app-ui-platform	15.61% <25.03%> (+0.54%)	⬆️
app-ui-vault	26.55% <12.27%> (+0.76%)	⬆️
authenticator	6.61% <16.81%> (-0.07%)	⬇️
lib-core-network-bridge	4.26% <4.64%> (-0.02%)	⬇️
lib-data-ui	0.93% <0.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[claude]

Claude finished @david-livefront's task in 3m 13s —— View job

---

Review Summary: Remove remember ViewModel

Reviewed commit: 8b4724526 (Remove remember ViewModel)
Risk level: Low - mechanical refactoring with well-defined pattern

Overview

This PR removes remember(viewModel) { { ... } } lambda wrappers from 74 files across all modules (app, authenticator, testharness) and documentation. The change relies on Compose strong skipping mode to handle lambda memoization automatically, eliminating the need for manual remember wrapping.

Findings

No issues found. This is a clean, well-executed mechanical refactoring.

Verification Summary

Check	Result
Pattern replacement correctness	All ~442 remember(viewModel) lambda wrappers correctly unwrapped
Non-lambda remember preserved	All ~40 Handler object remember(viewModel) instances correctly kept (e.g., SendHandlers.create(), SearchHandlers.create())
remember import removal correct	Verified files only lose the import when no remaining remember calls exist
No missed instances	All remaining remember(viewModel) are for computed objects, not lambda callbacks
Documentation consistent	CLAUDE.md, SKILL.md, templates.md, and ARCHITECTURE.md all updated to remove remember(viewModel) guidance
No behavioral changes	All lambda bodies are preserved exactly; only the remember wrapper is removed

Notes

• Two remember {} (without viewModel key) in authenticator ExportScreen.kt and ImportingScreen.kt were also correctly removed, consistent with the PR's purpose.
• ViewSendScreen.kt includes a minor unrelated cleanup (LocalContext.current → LocalResources.current), which is a trivial improvement.

Status: Approved - No issues to address.

[SaintPatrck]

👍

[david-livefront]

Thanks @SaintPatrck