PM-29871: Add additional callouts for external links in the app

[david-livefront]

🎟️ Tracking

PM-29871

📔 Objective

This PR adds additional callouts to external links within the app. This was done by adding the trailing , Eternal link announcement or by ensuring that all links have custom accessibility actions associated with them.

[claude]

Claude finished @david-livefront's task in 3m 59s —— View job

---

• Gather context and understand the changes
• Review code changes
• Post review feedback

Review Summary

PR: PM-29871: Add additional callouts for external links in the app
Risk Level: Low

Overview

This PR improves accessibility by adding "External link" callouts to UI elements that navigate users outside the app. The changes touch 29 files and are well-structured around three main themes:

1. Centralized help button abstraction — Renames TooltipData to BitwardenHelpButtonData with a new isExternalLink property, and introduces BitwardenHelpIconButton to consolidate rendering logic and external link content description formatting.

2. Overflow menu external link support — Adds isExternalLink to OverflowMenuItemData and extracts BitwardenDropdownMenuItem to handle the accessibility announcement ("{text}, External link") with proper hideFromAccessibility() on the child Text to avoid double announcements.

3. Hypertext link standardization — Replaces manual annotatedStringResource + CustomAccessibilityAction patterns in QR code screens and import logins with the existing BitwardenHyperTextLink composable, reducing code duplication.

Findings

No issues found. The changes are consistent across all affected components. Specific observations:

• The isExternalLink values are correctly assigned at all call sites (including false for the Privileged Apps help which navigates in-app).
• The QR code screen color change from hardcoded Color.White to BitwardenTheme.colorScheme.text.primary is safe because those screens force dark theme via CompositionLocalProvider.
• The hideFromAccessibility() pattern in BitwardenDropdownMenuItem correctly prevents double announcements when isExternalLink is true.
• Component refactoring in UI components (BitwardenTextField, BitwardenPasswordField, BitwardenSwitch, etc.) properly propagates the renamed BitwardenHelpButtonData parameter.
• Test updates align with the parameter renames.

Verdict

✅ LGTM — Clean accessibility improvement with good component abstractions and consistent application across the codebase.

[david-livefront]

I moved this to be more associated with the new BitwardenHelpIconButton. Additionally, I renamed it to match the new button and distinguish it from the existing Tooltips we already have in the app.

[github-actions]

Checkmarx One – Scan Summary & Details – 759a9c38-c898-48aa-a972-46721708a113

Great job! No new security vulnerabilities introduced in this pull request

[codecov]

Codecov Report

❌ Patch coverage is 92.15686% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.55%. Comparing base (fa4347d) to head (d11f8db).
⚠️ Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
...tor/ui/platform/feature/settings/SettingsScreen.kt	77.77%	2 Missing ⚠️
...en/ui/vault/feature/qrcodescan/QrCodeScanScreen.kt	88.88%	1 Missing ⚠️
...thenticator/feature/qrcodescan/QrCodeScanScreen.kt	90.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6614      +/-   ##
==========================================
+ Coverage   85.52%   85.55%   +0.03%     
==========================================
  Files         846      932      +86     
  Lines       58681    59451     +770     
  Branches     8348     8365      +17     
==========================================
+ Hits        50185    50862     +677     
- Misses       5604     5687      +83     
- Partials     2892     2902      +10     

Flag	Coverage Δ
app-data	17.60% <0.00%> (+0.33%)	⬆️
app-ui-auth-tools	21.15% <5.88%> (+0.32%)	⬆️
app-ui-platform	15.67% <11.76%> (+0.61%)	⬆️
app-ui-vault	26.51% <43.13%> (-0.04%)	⬇️
authenticator	6.61% <31.37%> (+<0.01%)	⬆️
lib-core-network-bridge	4.27% <0.00%> (-0.01%)	⬇️
lib-data-ui	0.93% <0.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[SaintPatrck]

👍

[david-livefront]

Thanks @SaintPatrck