Skip to content

[PM-29014] Update BitwardenPasswordField semantics to support accessibility for visible passwords #6222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SaintPatrck wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[PM-29014] Update BitwardenPasswordField semantics to support accessibility for visible passwords #6222

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ae5e4ca
Update BitwardenPasswordField semantics to support accessibility for …
SaintPatrck Dec 3, 2025
da57763
Fix logic for password field content description
SaintPatrck Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions ui/src/main/kotlin/com/bitwarden/ui/platform/components/field/BitwardenPasswordField.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,9 @@ import androidx.compose.ui.platform.LocalFocusManager
import androidx.compose.ui.platform.LocalTextToolbar
import androidx.compose.ui.platform.TextToolbar
import androidx.compose.ui.res.stringResource
import androidx.compose.ui.semantics.contentDescription
import androidx.compose.ui.semantics.isSensitiveData
import androidx.compose.ui.semantics.semantics
import androidx.compose.ui.text.input.ImeAction
import androidx.compose.ui.text.input.KeyboardType
import androidx.compose.ui.text.input.PasswordVisualTransformation
Expand Down Expand Up @@ -228,6 +231,19 @@ fun BitwardenPasswordField(
)
},
modifier = Modifier
.semantics {
// Content description must be set to the field value in order for Talkback
// to speak the password aloud when it is visible because we apply a custom
// VisualTransformation to the text, which prevents Talkback from reading
// the value as it normally would.
// NOTE: This overrides the default behavior of Talkback's "Speak Passwords"
// setting. When visible, the password will always be spoken aloud
// regardless of the user's configuration.
contentDescription = textFieldValue.text
.takeIf { showPassword }
.orEmpty()
isSensitiveData = true
}
.nullableTestTag(tag = passwordFieldTestTag)
.fillMaxWidth()
.onFocusChanged { focusState -> focused = focusState.isFocused },
Expand Down
Loading