Skip to content

PM-26896: Fix Autofill ancestry#6014

Draft
david-livefront wants to merge 1 commit intomainfrom
PM-26896-autofill-fix
Draft

PM-26896: Fix Autofill ancestry#6014
david-livefront wants to merge 1 commit intomainfrom
PM-26896-autofill-fix

Conversation

@david-livefront
Copy link
Collaborator

@david-livefront david-livefront commented Oct 13, 2025

🎟️ Tracking

PM-26896

📔 Objective

This PR updates the way Autofill works in order to avoid misaddressing the username/password to the wrong web-domain which can leak user data.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@david-livefront david-livefront added the hold do not merge yet label Oct 13, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 13, 2025

Logo
Checkmarx One – Scan Summary & Details38fac37d-2bd9-43e6-ae80-bbca8e687325

Great job! No new security vulnerabilities introduced in this pull request

@codecov
Copy link

codecov bot commented Oct 13, 2025

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 86.47%. Comparing base (06284a3) to head (e5980c9).

Files with missing lines Patch % Lines
...twarden/data/autofill/parser/AutofillParserImpl.kt 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6014      +/-   ##
==========================================
+ Coverage   86.43%   86.47%   +0.03%     
==========================================
  Files         798      797       -1     
  Lines       56989    56928      -61     
  Branches     8265     8264       -1     
==========================================
- Hits        49258    49226      -32     
+ Misses       4862     4833      -29     
  Partials     2869     2869              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@david-livefront david-livefront force-pushed the PM-26896-autofill-fix branch 5 times, most recently from 9bac36e to 70111b2 Compare October 21, 2025 18:23
@david-livefront david-livefront force-pushed the PM-26896-autofill-fix branch 2 times, most recently from 182091c to 4bac810 Compare November 7, 2025 22:03
@github-actions github-actions bot added app:password-manager Bitwarden Password Manager app context t:misc Change Type - ¯\_(ツ)_/¯ and removed hold do not merge yet labels Jan 9, 2026
@david-livefront david-livefront added t:bug Change Type - Bug and removed t:misc Change Type - ¯\_(ツ)_/¯ labels Feb 20, 2026
@david-livefront david-livefront added ai-review Request a Claude code review labels Feb 20, 2026
@github-actions github-actions bot removed ai-review Request a Claude code review t:bug Change Type - Bug labels Feb 20, 2026
@david-livefront david-livefront added ai-review Request a Claude code review t:bug Change Type - Bug labels Feb 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request a Claude code review app:password-manager Bitwarden Password Manager app context t:bug Change Type - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant