allows to change an array of classes for the parameters of 'from' and 'to'.#15
Open
sejoalfaro wants to merge 3 commits intobitshadow:masterfrom
Open
allows to change an array of classes for the parameters of 'from' and 'to'.#15sejoalfaro wants to merge 3 commits intobitshadow:masterfrom
sejoalfaro wants to merge 3 commits intobitshadow:masterfrom
Conversation
bitshadow
reviewed
Jun 4, 2019
bitshadow
requested changes
Jun 4, 2019
Owner
bitshadow
left a comment
bitshadow
left a comment
There was a problem hiding this comment.
Thanks @TheJoseScream for the PR. I have added feedback for minor change.
Author
|
Hi dear, I thought better of the solution, I think the ideal is to always send a string and be separated by spaces. I have already tried it and in my opinion it looks much better. I dont know if make a new pullrequest, I remain attentive to your response, thanks. |
sejoalfaro
commented
Jun 6, 2019
Author
sejoalfaro
left a comment
sejoalfaro
left a comment
There was a problem hiding this comment.
hello, I think the best way to do it is to send a string where each class is separated by a space and then grab that string and convert it into an array to go through it.
sejoalfaro
commented
Jun 13, 2019
Author
sejoalfaro
left a comment
sejoalfaro
left a comment
There was a problem hiding this comment.
what do you think about this solution?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hello, greetings and I hope you are well. I had the problem that I could only put one class and the solution I found is sending an array of classes.
Thank you!