Conversation
Contributor
|
Please resolve merge conflicts @nskong |
Contributor
|
Also the "files changed" is always very high, I've tried to fix it by updating from master, but without isolating your team's changes, I won't ever be able to give an honest review. This has been a recurring issues so in the future please try to fix this before setting your pull req. And also make sure your PR only contains the changes that your team made. @nskong |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues Closed
Closes #682
Closes #683
Closes #684
Closes #685
Closes #686
...
Changes proposed in this pull request:
@kavuong