This repository was archived by the owner on Apr 3, 2019. It is now read-only.
Fix parsing uint64 fields with values >= 2^32#39
Open
gabmontes wants to merge 1 commit intobitpay:masterfrom
bloq:fix-large-output-amount
Open
Fix parsing uint64 fields with values >= 2^32#39gabmontes wants to merge 1 commit intobitpay:masterfrom bloq:fix-large-output-amount
gabmontes wants to merge 1 commit intobitpay:masterfrom
bloq:fix-large-output-amount
Conversation
The amount field in an Output message is 64 bits long and is represented in the JavaScript side using a Long object. When its value is get through the PaymentProtocol interface, it is parsed using the toInt(). toInt() interprets the Long object as 32 bit so amounts larger than 2^32 will be incorrectly parsed i.e. when an output has an amount larger than 42.9 BTC. The same issue applies to the PaymentDetails/PaymentRequest messages as time and expires fields are uint64 too. If time or expires are larger than 2^32, get operations on those fields will return incorrect values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The amount field in an Output message is 64 bits long and is represented
in the JavaScript side using a Long object. When its value is get
through the PaymentProtocol interface, it is parsed using the toInt().
toInt() interprets the Long object as 32 bit so amounts larger than 2^32
will be incorrectly parsed i.e. when an output has an amount larger than
42.9 BTC.
The same issue applies to the PaymentDetails/PaymentRequest messages as
time and expires fields are uint64 too. If time or expires are larger
than 2^32, get operations on those fields will return incorrect values.