feat: add password reset flow #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
bitnimble
requested changes
Jan 19, 2026
| } | ||
|
|
||
| runInAction(() => (this.store.submitting = true)); | ||
| const redirectTo = `${window.location.origin}${routeFor([RoutePath.UPDATE_PASSWORD])}`; |
Owner
There was a problem hiding this comment.
use the baseUrl env var instead of window.location.origin
src/app/reset-password/page.tsx
Outdated
| import { ResetPassword } from './reset_password'; | ||
| import { ResetPasswordPresenter, ResetPasswordStore } from './reset_password_presenter'; | ||
|
|
||
| function createResetPasswordPage(supabase: ReturnType<typeof useApi>['supabase']) { |
Owner
There was a problem hiding this comment.
no need to DI supabase, it should be possible to use the global create in the presenter directly instead of drilling
src/app/reset-password/page.tsx
Outdated
|
|
||
| return observer(() => { | ||
| return ( | ||
| <ResetPassword |
Owner
There was a problem hiding this comment.
inline the contents of reset_password.tsx into here instead of a separate file
src/app/update-password/page.tsx
Outdated
| import { UpdatePassword } from './update_password'; | ||
| import { UpdatePasswordPresenter, UpdatePasswordStore } from './update_password_presenter'; | ||
|
|
||
| function createUpdatePasswordPage(supabase: ReturnType<typeof useApi>['supabase']) { |
src/app/update-password/page.tsx
Outdated
|
|
||
| return observer(() => { | ||
| return ( | ||
| <UpdatePassword |
Owner
There was a problem hiding this comment.
ditto here, no need for a separate file for this component
| }); | ||
| } | ||
|
|
||
| onChangePassword = (value: string) => (this.store.password = value); |
| private readonly store: UpdatePasswordStore | ||
| ) { | ||
| super(store); | ||
| makeObservable(this, { |
Owner
There was a problem hiding this comment.
remove in favour of wrapping the function definition in the action directly
| private readonly store: ResetPasswordStore | ||
| ) { | ||
| super(store); | ||
| makeObservable(this, { |
Owner
There was a problem hiding this comment.
remove in favour of wrapping the function definition in mobx.action.bound directly
src/utils/routes.ts
Outdated
| MAP = 'map', | ||
| LOGIN = 'login', | ||
| LOGOUT = 'logout', | ||
| RESET_PASSWORD = 'reset-password', |
Owner
There was a problem hiding this comment.
make the reset path /password/reset, and the update route /password/reset/update
Contributor
Author
|
Claude finished @banana-claude[bot]'s task in 4m 32s —— View job Addressed all review comments
Changes pushed to claude/issue-22-20260106-1209. @bitnimble ready for re-review. |
bitnimble
approved these changes
Jan 20, 2026
- Add /reset-password page to request password reset email - Add /update-password page to set new password from reset link - Add "Forgot password?" link on login page - Uses Supabase Auth resetPasswordForEmail and updateUser APIs Co-authored-by: bitnimble <bitnimble@users.noreply.github.com>
- Move routes from /reset-password and /update-password to /password/reset and /password/reset/update - Inline separate component files into page.tsx - Use global createClient() instead of DI for supabase - Use action.bound and setSubmitting/setSuccess helpers instead of runInAction - Use NEXT_PUBLIC_BASE_URL env var instead of window.location.origin Co-authored-by: bitnimble <bitnimble@users.noreply.github.com>
bitnimble
force-pushed
the
claude/issue-22-20260106-1209
branch
from
7ffbd28 to
fda66ec
Compare
banana-claude bot
pushed a commit
that referenced
this pull request
Jan 20, 2026
Add new sections covering: - React patterns (mobx-react-lite, observer structure, page.tsx patterns) - MobX conventions (action.bound, makeObservable generics) - Dependency injection (prefer createClient() at usage site) - Routing conventions (nested routes over hyphens) - Forms/UX (password confirmation, required fields) - TypeScript (don't export internal types) These guidelines address patterns that required manual fixes in the password reset feature implementation. Closes #55 Co-authored-by: bitnimble <bitnimble@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
/reset-passwordpage to request password reset email via Supabase Auth/update-passwordpage to set new password from reset linkCloses #22
Generated with Claude Code