-
Notifications
You must be signed in to change notification settings - Fork 1
state uploads and session matching #147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -88,8 +88,11 @@ message Workflow { | |
| message Rule { | ||
| oneof rule_type { | ||
| option (validate.required) = true; | ||
|
|
||
| RuleLogMatch rule_log_match = 1; | ||
| RuleStateChangeMatch rule_state_change_match = 3; | ||
| // This will match when a new session starts. | ||
| bool on_new_session = 4; | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I thought about using
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this makes sense in general since using RuleStateChangeMatch would expose the actual session ID for matching which I think adds more complexity than is necessary |
||
| } | ||
|
|
||
| reserved 2; | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so during offline reconnect we'd just be sending the latest value of this? any reason we'd want to be able to see all changes or do we think that it's low frequency enough that this doesn't matter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose I could make this keep track of all changes as I'm going to do with sessions it just seems like an extreme edge case. I will discuss with @Reflejo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per offline convo for now we will just send the most recent one. We are going to store entity changes in state though which should make changes visible in timeline once we finish that work.