Register custom exceptions for Python bindings#6
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces dedicated Python exception types for the Rust-backed cflib2 bindings, so Python callers can catch specific Crazyflie error conditions rather than a generic runtime error.
Changes:
- Add a set of custom PyO3 exception types mirroring
crazyflie_lib::Errorvariants and map Rust errors to these Python exceptions. - Register the exception types in the
_rustPython module during module initialization. - Re-export the exceptions from
cflib2/__init__.pyand include them in__all__.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| rust/src/lib.rs | Registers the new exception types with the _rust module at import time. |
| rust/src/error.rs | Defines custom exceptions, registers them on the module, and updates to_pyerr to return specific exception subclasses. |
| cflib2/init.py | Re-exports the new exceptions at the package root and updates __all__. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
9751f2d to
1f62f39
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.