build: move hardening flags to dedicated cmake module#254
Open
kwsantiago wants to merge 1 commit intobitcoinknots:29.x-knotsfrom
Open
build: move hardening flags to dedicated cmake module#254kwsantiago wants to merge 1 commit intobitcoinknots:29.x-knotsfrom
kwsantiago wants to merge 1 commit intobitcoinknots:29.x-knotsfrom
Conversation
kwsantiago
force-pushed
the
cmake-hardening-module
branch
from
43d47e4 to
ff44a2f
Compare
luke-jr
requested changes
Feb 3, 2026
kwsantiago
force-pushed
the
cmake-hardening-module
branch
2 times, most recently
from
a6cead3 to
c9765f0
Compare
Ari4ka
approved these changes
Feb 17, 2026
There was a problem hiding this comment.
Pull request overview
Refactors the CMake hardening flag setup out of the top-level CMakeLists.txt into a dedicated cmake/module/Hardening.cmake module to centralize and reuse the hardening configuration.
Changes:
- Add
cmake/module/Hardening.cmakeprovidingsetup_hardening(target). - Include the new Hardening module from the top-level
CMakeLists.txt. - Replace the inlined hardening flag setup in
CMakeLists.txtwith a singlesetup_hardening(core_interface)call.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| cmake/module/Hardening.cmake | New module encapsulating hardening-related compile/link flag logic behind setup_hardening(). |
| CMakeLists.txt | Switches from inlined hardening logic to using the new module helper. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kwsantiago
force-pushed
the
cmake-hardening-module
branch
4 times, most recently
from
91ad97b to
18308c0
Compare
kwsantiago
force-pushed
the
cmake-hardening-module
branch
from
18308c0 to
5c77cb5
Compare
Ari4ka
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#237 (review)