rpc: add expiry field to getgeneralinfo#247
Open
Retropex wants to merge 1 commit intobitcoinknots:29.x-knotsfrom
Open
rpc: add expiry field to getgeneralinfo#247Retropex wants to merge 1 commit intobitcoinknots:29.x-knotsfrom
Retropex wants to merge 1 commit intobitcoinknots:29.x-knotsfrom
Conversation
|
Knots exposing expiry via RPC is the correct layer. |
Collaborator
|
Not sure having its own RPC makes sense. Maybe one of the existing get*info is a good place? |
Author
|
Make sense, I will update |
luke-jr
requested changes
Jan 29, 2026
Retropex
force-pushed
the
rpcexpiry
branch
2 times, most recently
from
5b1eef4 to
86b4d02
Compare
luke-jr
requested changes
Feb 3, 2026
Retropex
changed the title
Retropex
force-pushed
the
rpcexpiry
branch
2 times, most recently
from
2820f17 to
27d5725
Compare
Ari4ka
approved these changes
Feb 17, 2026
Author
|
Instead of mixing types, I have moved the timestamp in a JSON object and added a status field that return true of false depending on if bitcoind is set to expire or not. |
Ari4ka
approved these changes
Apr 15, 2026
Collaborator
|
How about [going back to a single field and] just using maxint if expiry is disabled? |
Author
|
Like returning |
Ari4ka
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Useful for external software who want to be able to fetch when
bitcoindwill expire.