Skip to content

chore: upgrade wif to v4.0.0#81

Closed
ChrisCho-H wants to merge 1 commit intobitcoinjs:masterfrom
ChrisCho-H:chore/upgrade-wif
Closed

chore: upgrade wif to v4.0.0#81
ChrisCho-H wants to merge 1 commit intobitcoinjs:masterfrom
ChrisCho-H:chore/upgrade-wif

Conversation

@ChrisCho-H
Copy link
Copy Markdown
Contributor

update wif following bitcoinjs/wif#30
this will prevent error caused by crypto libs in browser or mobile

@junderw
Copy link
Copy Markdown
Member

junderw commented Aug 30, 2023

I would rather remove wif.

In a BIP32 world, wif is unnecessary.

Even if you need it, you can always do wif.encode(node.privateKey)

@junderw junderw closed this Aug 30, 2023
@ChrisCho-H
Copy link
Copy Markdown
Contributor Author

bip32 has a function toWIF() which has a dependency on wif.
do u think that module is also better to be removed?

@junderw
Copy link
Copy Markdown
Member

junderw commented Aug 30, 2023

Yes, that is what I meant when I said we should remove it.

It would be a breaking change, so I've been putting it off, I should have removed it when we updated for taproot.

@ChrisCho-H
Copy link
Copy Markdown
Contributor Author

I made PR #82 to remove wif

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants