fix(types): avoid reachable panics in Utxo::txout for Foreign variant#487
Merged
ValuedMammal merged 1 commit intoMay 13, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #487 +/- ##
==========================================
+ Coverage 80.30% 80.55% +0.25%
==========================================
Files 24 24
Lines 5417 5472 +55
Branches 245 243 -2
==========================================
+ Hits 4350 4408 +58
+ Misses 989 987 -2
+ Partials 78 77 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
5 tasks
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Utxo::txout()contained two reachable panics for theForeignvariant:prev_tx.output[outpoint.vout as usize]— panics ifnon_witness_utxohas fewer outputs thanoutpoint.voutunreachable!("Foreign UTXOs will always have one of these set")— asserts an invariant the type does not enforce, reachable via direct construction ofUtxo::Foreignwith an emptypsbt::InputAddresses part of #474
Notes to the reviewers
Collapsed the two
if letarms and theunreachable!into a single chainedOption, replacing the index access with.get()to safely handle out-of-bounds vout, and replacingunreachable!with.expect().This is the short-term non-breaking fix. A follow-up will change the function signature to
pub fn txout(&self) -> Option<&TxOut>as a breaking change targeting Wallet 4.0.0.All Submissions:
just pbefore pushingNew Features:
Bugfixes: