Skip to content

fix(psbt): sanity check psbt before signing#486

Open
sdmg15 wants to merge 1 commit into
bitcoindevkit:masterfrom
sdmg15:fix/sanity-check-psbt-before-signing
Open

fix(psbt): sanity check psbt before signing#486
sdmg15 wants to merge 1 commit into
bitcoindevkit:masterfrom
sdmg15:fix/sanity-check-psbt-before-signing

Conversation

@sdmg15
Copy link
Copy Markdown

@sdmg15 sdmg15 commented May 12, 2026

Description

This PR attempts to sanity check the PSBT before signing. It closes audit issue #52

Notes to the reviewers

Changelog notice

Checklists

All Submissions:

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@codecov
Copy link
Copy Markdown

codecov Bot commented May 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.39%. Comparing base (4b612f5) to head (f0aca23).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #486      +/-   ##
==========================================
+ Coverage   80.30%   80.39%   +0.09%     
==========================================
  Files          24       24              
  Lines        5417     5432      +15     
  Branches      245      246       +1     
==========================================
+ Hits         4350     4367      +17     
+ Misses        989      988       -1     
+ Partials       78       77       -1     
Flag Coverage Δ
rust 80.39% <100.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

1 participant