test(utils): add boundary tests for Older::check_older and After::check_after#443
Open
KrishnaShuk wants to merge 1 commit into
Open
test(utils): add boundary tests for Older::check_older and After::check_after#443KrishnaShuk wants to merge 1 commit into
KrishnaShuk wants to merge 1 commit into
Conversation
KrishnaShuk
requested review from
ValuedMammal and
oleonardolima
as code owners
busayo-OD
reviewed
May 11, 2026
| let after = After::new(Some(100_000), false); | ||
| assert!(Satisfier::<PublicKey>::check_after( | ||
| &after, | ||
| absolute::LockTime::from_consensus(100_000) |
There was a problem hiding this comment.
absolute::LockTime can also represent Unix timestamps (>= 500_000_000), but After only has current_height and no current_time. So a timestamp-based locktime would end up being compared against a block height. I also noticed the existing tests don't cover this. Is this intentionally limited to height-based locktimes for now?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Addresses the
// TODO: test >= / >on line 111 of utils.rs. Adds 11 boundary-condition tests for theSatisfierimpls of Older and After.Notes to the reviewers
Uses
Satisfier::<PublicKey>::check_older(...)fully-qualified syntax because the trait is generic overPk.Changelog notice
Checklists
All Submissions:
just pbefore pushingNew Features:
Bugfixes: