Skip to content

fix(create_tx): enforce single recipient for send_all #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1estart wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(create_tx): enforce single recipient for send_all #291

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ Changelog info is also documented on the [GitHub releases](https://github.com/bi
page. See [DEVELOPMENT_CYCLE.md](DEVELOPMENT_CYCLE.md) for more details.

## [Unreleased]
- Fixed `create_tx --send_all` to reject multiple recipients instead of silently using only the first one

## [3.0.0]

Expand Down
8 changes: 7 additions & 1 deletion src/handlers.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -540,7 +540,13 @@ pub fn handle_offline_wallet_subcommand(
let mut tx_builder = wallet.build_tx();

if send_all {
tx_builder.drain_wallet().drain_to(recipients[0].0.clone());
if recipients.len() == 1 {
tx_builder.drain_wallet().drain_to(recipients[0].0.clone());
} else {
return Err(Error::Generic(
"Wallet can only be drained to a single output".to_string(),
));
}
} else {
let recipients = recipients
.into_iter()
Expand Down