Open
Conversation
…list Security Issue: - The check_privilege method was directly calling constantize on privilege.privilege_name without validation - This allowed potential Remote Code Execution if an attacker could control the privilege_name field in the database Solution: - Added ALLOWED_PRIVILEGES whitelist containing only valid model names - check_privilege now validates privilege names against whitelist - Non-whitelisted attempts are logged and rejected - Maintains backward compatibility for legitimate privileges Allowed Models: Proposal, ProposalType, Location, Schedule, User, Role, Answer, Email, Review, Subject, Participant Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Added missing models discovered during staging testing: - AmsSubject, DemographicData, EmailTemplate - Faq, Feedback, Invite, Option - PageContent, Person, ProposalField, ProposalForm - StaffDiscussion, Survey, Validation, SubjectCategory - SchedulesController, SubmittedProposalsController Alphabetically sorted for maintainability. Testing on pstaging revealed these models are used by existing Staff role privileges. Without these in the whitelist, legitimate admin/staff operations were being blocked. Security remains intact: only explicit whitelisted classes can be used in privilege definitions, preventing RCE via constantize. Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Ian Allison <iana@pims.math.ca>
Signed-off-by: Ian Allison <iana@pims.math.ca>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update rails and fix role ability checks