Fix duplicate RIT assignment bug with database locking#1044
Open
bigsnarfdude wants to merge 6 commits intoreleasesfrom
Open
Fix duplicate RIT assignment bug with database locking#1044bigsnarfdude wants to merge 6 commits intoreleasesfrom
bigsnarfdude wants to merge 6 commits intoreleasesfrom
Conversation
Collaborator
bigsnarfdude
commented
Jul 21, 2025
bigsnarfdude
commented
- Add transaction wrapper with database locking to prevent race conditions
- Implement retry mechanism with exponential backoff
- Add error logging for failed code generation attempts
- Prevents duplicate proposal codes during concurrent submissions
- Add transaction wrapper with database locking to prevent race conditions - Implement retry mechanism with exponential backoff - Add error logging for failed code generation attempts - Prevents duplicate proposal codes during concurrent submissions 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
ianabc
approved these changes
Jul 21, 2025
Collaborator
ianabc
left a comment
ianabc
left a comment
There was a problem hiding this comment.
This looks good to me, I don't know the logic in detail, but it looks like it would raise then catch an ActiveRecord error if a duplicate code was selected during proposal creation. It would be good to check check that the exception is caught and logged on staging (and isn't caught when there is no conflict). Beyond that, I think this is ready to go.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.