Open
Conversation
…ys within the values array
…tyle update $12383e67
…e format string. This unfortunately hides the error but is necessary if we want to be "flexible" with the data we unpack. If the format string is longer than the supplied data it will return as much unpacked fields as it can before it runs out of data.
…packing formats with less data than required. If this is needed a 3rd argument has to be supplied to Unpack(). Added tests to validate that functionality for Unpack and Pack. Other changes - updated dependencies - added eslint with standard config only as placeholder for now
|
Is there a timeline when this pull request is going to be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a number of issues:
Adding a new feature:
This has been in use for a while now and seems to be very stable. Would be great to get the npm package updated.
Open questions: