[FIX] widget: Make controlAreaVisible a global setting#282
Draft
ales-erjavec wants to merge 1 commit intobiolab:masterfrom
Draft
[FIX] widget: Make controlAreaVisible a global setting#282ales-erjavec wants to merge 1 commit intobiolab:masterfrom
ales-erjavec wants to merge 1 commit intobiolab:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #282 +/- ##
=======================================
Coverage 72.03% 72.03%
=======================================
Files 34 34
Lines 9117 9117
=======================================
Hits 6567 6567
Misses 2550 2550 ☔ View full report in Codecov by Sentry. |
Member
|
@ales-erjavec, thanks, this change means that now a newly added widget could be shown with a hidden control area. @janezd (and me) pointed out that for new widgets, the control area should always be shown. The size is problematic: if a default was saved with a hidden control area, the new widget size should be increased in width by the control area size. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Make controlAreaVisible a global setting along the widget geometry.
Description of changes
Make controlAreaVisible a global setting
Includes