Fix DNAmTL intercept sign#205
Merged
marcbal77 merged 1 commit intobio-learn:masterfrom Apr 21, 2026
Merged
Conversation
Member
Author
|
Hey @sarudak, quick fix here - the DNAmTL intercept had a wrong sign, was negative instead of positive. Matches the Lu et al. paper now. Tests all pass, good to merge when you get a chance. |
sarudak
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The DNAmTL intercept was stored as -7.924780053 but should be +7.924780053 per the original Lu et al. manuscript. This was producing negative telomere length estimates. Updated the coefficient and regenerated expected test outputs.
Closes #204