Open
Conversation
arai-a
reviewed
May 13, 2019
arai-a
left a comment
arai-a
left a comment
There was a problem hiding this comment.
haven't yet done Nodes and probabilities part.
will review shortly.
arai-a
reviewed
May 13, 2019
|
|
||
|
|
||
| ## Probability dictionaries | ||
|
|
There was a problem hiding this comment.
how about adding something like the following?
(just suggestion for later changes, not that they should be added in this PR)
- the dictionary defines the possible AST, and code for each possibility to encode the actual tree in tree part of the file
- the possible AST is the subset of the valid ECMAScript AST
- If there's only one possibility at some node, it's fully defined in the dictionary
- if there's 2 or more possibilities at some node, code in tree part defines which possibility to choose at that node
- primitives values (excluding strings) and the length of lists are all defined in this dictionary, not in tree part
Author
There was a problem hiding this comment.
I've tried clarifying in the latest version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's a first attempt at specifying the format.
@dominiccooney, did I get it right?