Fixes #118 and #119#121
Open
cagdas001 wants to merge 4 commits intobillsedison:tc-devfrom
Open
Conversation
…n the PR description)
cagdas001
added a commit
to cagdas001/vscode-gitlens
that referenced
this pull request
Jan 5, 2019
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #118 #119
getBlameForFileRevision and blame_revision functions have been implemented, in order to get blame data of lines for specific revisions/commits.
Even though line numbers are different (document has changes), the target line will be detected correctly.
CommentLine, which has To and From fields, has been implemented.
Details about BitBucket API
commentsendpointIt was adding and getting all comments in/from to field before, now it detects the field which should be used, and sends/gets the line number within it. This field is important if you'll add/show (or other actions) on a deleted/added/changed line.
To understand the difference and importance of these fields, see the screencast.
Linefield ofCommentTherefore we're keeping it for now, not to cause any issue in other partsTESTED CASES
For your reference. Below cases tested on my side and haven't had any issue.
Note: In the Edit mode, Current commit is the last commit that made a change on this file
Your actions should affect only the related line, even if their line numbers would be same.
KNOWN ISSUE
In case of multiple DiffViews are opened, only the last one will work properly with the existing code. So I have not fixed it and went with the same way that the existing code uses. Let me know if we need to fix this