Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1067 +/- ##
=======================================
Coverage 66.24% 66.24%
=======================================
Files 89 89
Lines 17064 17064
Branches 2642 2642
=======================================
Hits 11304 11304
Misses 5021 5021
Partials 739 739
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
The latest jobs are failing because:
|
GregoryAshton
approved these changes
Apr 2, 2026
Collaborator
GregoryAshton
left a comment
There was a problem hiding this comment.
I read over the MR and it looks good to me.
adivijaykumar
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CI tests are pretty broken again. I'm not sure if this is due to changes I made or not.
I added some tests to the containers between building and pushing them, so hopefully we won't have broken containers being pushed in the future.
Summary of changes:
SETUPTOOLS_SCM_IGNORE_DUBIOUS_OWNER=1. This tells setuptools_scm to ignore the fact that it is being run in a repository the user doesn't own.I don't understand why the user doesn't own the repository anymore, but this fixes the problem at least.
As usual, if this isn't merged by midnight the old container will be rebuilt and things will start breaking again.
I also reactivated the tests that our command line entry points work.