DEP: remove support for dynesty v2#1049
Open
ColmTalbot wants to merge 5 commits intobilby-dev:mainfrom
Open
Conversation
ColmTalbot
added
sampling
ColmTalbot
force-pushed
the
remove-old-dynesty
branch
from
f228b63 to
469957e
Compare
This was referenced Apr 1, 2026
Collaborator
GregoryAshton
left a comment
GregoryAshton
left a comment
There was a problem hiding this comment.
Overall looks good. Review tests would be needed to confirm sampling has not been impacted, but I don't see anything of significant concern.
| self.walks = (self.walks * delay + n_target / accept_prob) / (delay + 1) | ||
| self.kwargs["walks"] = min(int(np.ceil(self.walks)), _SamplingContainer.maxmcmc) | ||
| self.scale = tuning_info["accept"] | ||
| self.walks = (self.walks * delay + self.naccept / accept_prob) / (delay + 1) |
Collaborator
There was a problem hiding this comment.
Is this changing the way the walks is updated? Or am I misunderstanding the diff?
| logl = args.loglikelihood(current_v) | ||
|
|
||
| blob = { | ||
| sampling_info = { |
Collaborator
There was a problem hiding this comment.
Is there a reason the scale is no longer tracked?
| self.thin = getattr(_SamplingContainer, "nact", 2) | ||
| self.maxmcmc = getattr(_SamplingContainer, "maxmcmc", 5000) * 50 | ||
| self.thin = kwargs.get("nact", 2) | ||
| self.maxmcmc = kwargs.get("maxmcmc", 5000) * 50 |
Collaborator
There was a problem hiding this comment.
Should we make this 50 factor configurable?
| thin = self.thin * iact | ||
| blob = {"accept": accept, "reject": reject, "act": act} | ||
| iact = ACTTrackingEnsembleWalk.integer_act(act) | ||
| thin = args.kwargs.get("thin", 2) * iact |
Collaborator
There was a problem hiding this comment.
Is this setting a default thin of 2? Is that new or just change of where the default is set?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop support for older versions of dynesty for version 3.