Open
Conversation
teesloane
commented
Mar 27, 2025
| @impl true | ||
| def mount(socket) do | ||
| programs = for p <- Delivery.list_programs(), do: {p.name, p.id} | ||
| programs = for p <- Delivery.list_programs(), do: [key: p.name, value: p.id, label: p.name] |
Contributor
Author
There was a problem hiding this comment.
This was required in order to add "label" attributes to options in the <select> tag; these labels are used to traget dropdowns in tests.
teesloane
commented
Mar 27, 2025
| "assets.deploy": ["esbuild default --minify", "tailwind default --minify", "phx.digest"] | ||
| "assets.deploy": ["esbuild default --minify", "tailwind default --minify", "phx.digest"], | ||
| # REVIEW: Sometimes this hangs on a query - `INSERT INTO "tasks_items"...` | ||
| "test.e2e": ["ecto.drop", "phx.server"] |
Contributor
Author
There was a problem hiding this comment.
Not sure what's going on here—but it just seems to hang. Maybe just remove it?
teesloane
commented
Mar 27, 2025
Comment on lines
+43
to
+50
| name: 'firefox', | ||
| use: { ...devices['Desktop Firefox'] }, | ||
| }, | ||
|
|
||
| { | ||
| name: 'webkit', | ||
| use: { ...devices['Desktop Safari'] }, | ||
| }, |
Contributor
Author
There was a problem hiding this comment.
It might be worth removing testing for Firefox and Safari?
teesloane
commented
Mar 27, 2025
Comment on lines
+146
to
+149
| // once the program is created, we need to find it on the program page and EDIT it, | ||
| // because at this time there is no "add items" for part when creating a new program | ||
| // (only when editing it) |
Contributor
Author
There was a problem hiding this comment.
I wonder if this is an intentional part of the New Program form, or if the ability to add items should be possible in that form.
Member
|
Hmm is it possible to get this to at least run in the test database instead of dev in order to not wipe it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR adds Playwright e2e testing and a handful of example tests. A few notes:
I'd like to write more tests, but I also wanted to check in to see if this is going in the right direction first.
NOTE: At this time, running e2e tests just pollutes your local dev. So, I've been dropping the DB and resetting it before fresh runs. The tests have been written in a way to allow continuously running them, but it clutters your db. It may be possible to use the Ecto Sandbox to resolve this (here's a blog post going over that) but I didn't have any luck trying to set that up.
Checklist before requesting a review
about this update in the description above.
CleanShot.2025-03-27.at.15.23.00.mp4