Change cursor style on crosshair while selecting#71
Merged
bigfive merged 3 commits intobigfive:masterfrom Jan 15, 2016
Merged
Conversation
|
👍 |
Owner
|
Nice |
Contributor
Author
|
It's a bit late.. Should I fix conflicts? |
Contributor
Author
|
Fixed |
Owner
|
You're a star. Thanks |
bigfive
added a commit
that referenced
this pull request
Jan 15, 2016
Change cursor style on crosshair while selecting
Owner
|
Merged prematurely I'm afraid, had to revert. It looks like you removed middle mouse functionality |
Contributor
Author
|
Is it related to this lines? I've removed them because this method is not used anywhere. Am I wrong? |
Owner
|
Reopened here #84 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#12
Ready to discuss ideas about improvements.
We, probably, should trigger style change on _middleMouseDown event as well? Ideas?
It's a bit annoying that you have to move a cursor a bit after a key down to apply new style. Any ideas how to fix this?