Skip to content

fix: remove GitHub registry auth steps for npm install #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jairo-bc merged 1 commit into from
Apr 1, 2026
+0 −5
Merged

fix: remove GitHub registry auth steps for npm install #233

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,6 @@ jobs:
with:
node-version: '22.x'

# this is crucial for bodl-events package to be able to resolve @bigcommerce-labs scoped packages
Copy link
Copy Markdown

@cursor cursor bot Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registry auth removed inconsistently across workflow files

Medium Severity

The GitHub Packages auth steps for @bigcommerce-labs are removed from release.yml but remain in build.yml. The package-lock.json resolves @bigcommerce-labs/bodl-events from https://npm.pkg.github.com/, which typically requires authentication. If auth is truly unnecessary, the steps in build.yml are now redundant dead code; if auth is actually needed, npm i in the release workflow will fail when fetching this dependency.

Fix in Cursor Fix in Web

- name: Set npm registry
run: echo "@bigcommerce-labs:registry=https://npm.pkg.github.com/" >> ~/.npmrc
- name: Set npm secrets
run: echo "//npm.pkg.github.com/:_authToken=${{ secrets.DEPENDABOT_GITHUB_TOKEN }}" >> ~/.npmrc
- run: npm i
- name: Check Git Commit name
run: git log -1 --pretty=format:"%s" | npx commitlint
Expand Down
Loading