fix(core): TRAC-294 show manual checkout discounts in cart summary#3002
Open
bc-alexsaiannyi wants to merge 1 commit intocanaryfrom
Open
fix(core): TRAC-294 show manual checkout discounts in cart summary#3002bc-alexsaiannyi wants to merge 1 commit intocanaryfrom
bc-alexsaiannyi wants to merge 1 commit intocanaryfrom
Conversation
🦋 Changeset detectedLatest commit: ee0ff42 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Bundle Size ReportComparing against baseline from No bundle size changes detected. |
Contributor
Unlighthouse Performance Comparison — VercelComparing PR preview deployment Unlighthouse scores vs production Unlighthouse scores. Summary ScoreAggregate score across all categories as reported by Unlighthouse.
Category Scores
Core Web Vitals
|
jairo-bc
approved these changes
May 5, 2026
rtalvarez
approved these changes
May 5, 2026
chanceaclark
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TRAC-294
What/Why?
The cart’s “Discounts” row previously relied only on
cart.discountedAmount. Because of that, line item discounts applied via the Management Checkout API directly to the cart weren’t shown in the summary, so customers had no visibility into them.To fix this, we now account for both sources by adding each line item’s
discountedAmountto the cart-level discount. This way, the Cart summary accurately reflects what Shoppers see at checkout.Testing
Locally, using the following steps:
Before fix:
manual-item-discount_before-fix.mov
After fix:
manual-item-discount_after-fix.mov
Migration
No need