Skip to content

fix(auth): fall back to sessionStorage for session token (fixes getSessionToken() returning undefined on BBB 3.0.30+) #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BrentBaccala wants to merge 1 commit into
base: v0.0.x
Choose a base branch
from
Open

fix(auth): fall back to sessionStorage for session token (fixes getSessionToken() returning undefined on BBB 3.0.30+) #269

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions src/core/auxiliary/session-token/getter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,17 @@
export function getSessionToken(): string | undefined {
const params = new URLSearchParams(window.location.search);
return params.get('sessionToken') || undefined;
// BigBlueButton 3.0.30 (bigbluebutton/bigbluebutton#25219, "Hide sessionToken
// from URL bar") removes `sessionToken` from window.location during client
// startup and stores it in sessionStorage under the key `BBB_sessionToken`
// (ObservableStorage 'BBB_' prefix + 'sessionToken'). Plugins mount after that
// bootstrap, so reading only the URL returns undefined on 3.0.30+.
//
// Read the URL first (older cores, and the brief window before the strip),
// then fall back to sessionStorage so the token resolves on 3.0.30+ too.
const fromUrl = new URLSearchParams(window.location.search).get('sessionToken');
if (fromUrl) return fromUrl;
try {
return window.sessionStorage.getItem('BBB_sessionToken') || undefined;
} catch {
return undefined;
}
}
Loading