Skip to content

Fix(pylucxor): align fragment_error_units param with other algorithms#56

Merged
ypriverol merged 1 commit into
bigbio:mainfrom
yueqixuan:main
Jun 27, 2026
Merged

Fix(pylucxor): align fragment_error_units param with other algorithms#56
ypriverol merged 1 commit into
bigbio:mainfrom
yueqixuan:main

Conversation

@yueqixuan

@yueqixuan yueqixuan commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

--fragment-error-units --> --fragment-mass-unit

Summary by CodeRabbit

  • Bug Fixes

    • Corrected the fragment mass tolerance option name across the command line and workflow integration.
    • Updated the default configuration to use the same option name consistently.
  • Documentation

    • Aligned README and CLI docs with the current option name and updated the tolerance description.
    • Refreshed algorithm docs and examples to match the latest command usage.

@qodo-code-review

Copy link
Copy Markdown

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 6e41489f-8c83-4553-80f5-1d32ec0ada96

📥 Commits

Reviewing files that changed from the base of the PR and between a98c9e5 and 949cfd4.

📒 Files selected for processing (7)
  • .github/workflows/python-app.yml
  • README.md
  • docs/README.md
  • docs/algorithms/lucxor.md
  • onsite/lucxor/cli.py
  • onsite/lucxor/constants.py
  • onsite/onsitec.py

📝 Walkthrough

Walkthrough

LucXor’s fragment-unit option was renamed to fragment_mass_unit across the CLI path, default config, invocation sites, and documentation. Examples and the workflow test command now use --fragment-mass-unit.

Changes

LucXor fragment mass unit rename

Layer / File(s) Summary
CLI and config wiring
onsite/lucxor/constants.py, onsite/lucxor/cli.py, onsite/onsitec.py
The LucXor CLI option, command signatures, runner config update, default config key, call-site keywords, and one PSM-count log message use fragment_mass_unit.
Docs and workflow examples
README.md, docs/README.md, docs/algorithms/lucxor.md, .github/workflows/python-app.yml
The LucXor examples, options tables, algorithm guide, and real-data workflow command now use --fragment-mass-unit and the updated tolerance-units wording.

Sequence Diagram(s)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

Review effort 3/5

Suggested reviewers

  • ypriverol

Poem

🐰 I hopped through code with a jaunty thump,
Swapped error-units for a cleaner jump.
Now mass-unit shimmers in every line,
And the docs and tests both look just fine.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main change: renaming the fragment error units parameter to match other algorithms.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@ypriverol ypriverol merged commit bc2f726 into bigbio:main Jun 27, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants