Prevents illegal save on consecutive submits with invalid entries.#7
Open
lieblb wants to merge 1 commit intobheyser:trunkfrom
Open
Prevents illegal save on consecutive submits with invalid entries.#7lieblb wants to merge 1 commit intobheyser:trunkfrom
lieblb wants to merge 1 commit intobheyser:trunkfrom
Conversation
bheyser
pushed a commit
that referenced
this pull request
Jul 17, 2020
…n object that implements Countable Fixing error by using ldap-user-sync. replace debug message after checking for an array ERROR-LOG: ilCronManager::runJob:95 count(): Parameter must be an array or an object that implements Countable ilCronManager::runJob:95 #0 ILIAS_PATH/Services/Init/classes/class.ilErrorHandling.php(461): Whoops\Run->handleError(2, 'count(): Parame...', 'ILIAS_PATH...', 387) #1 ILIAS_PATH/Services/LDAP/classes/class.ilLDAPQuery.php(387): ilErrorHandling->handlePreWhoops(2, 'count(): Parame...', 'ILIAS_PATH...', 387, Array) #2 ILIAS_PATH/Services/LDAP/classes/class.ilLDAPQuery.php(131): ilLDAPQuery->fetchGroupMembers() #3 ILIAS_PATH/Services/LDAP/classes/class.ilLDAPCronSynchronization.php(87): ilLDAPQuery->fetchUsers() #4 ILIAS_PATH/Services/Cron/classes/class.ilCronManager.php(178): ilLDAPCronSynchronization->run() #5 ILIAS_PATH/Services/Cron/classes/class.ilCronManager.php(95): ilCronManager::runJob(Object(ilLDAPCronSynchronization), Array, true) #6 ILIAS_PATH/Services/Cron/classes/class.ilCronManagerGUI.php(282): ilCronManager::runJobManual('ldap_sync') #7 ILIAS_PATH/Services/Cron/classes/class.ilCronManagerGUI.php(64): ilCronManagerGUI->confirmedRun() #8 ILIAS_PATH/Services/UICore/classes/class.ilCtrl.php(210): ilCronManagerGUI->executeCommand() #9 ILIAS_PATH/Modules/SystemFolder/classes/class.ilObjSystemFolderGUI.php(152): ilCtrl->forwardCommand(Object(ilCronManagerGUI)) ILIAS-eLearning#10 ILIAS_PATH/Services/UICore/classes/class.ilCtrl.php(210): ilObjSystemFolderGUI->executeCommand() ILIAS-eLearning#11 ILIAS_PATH/Services/Administration/classes/class.ilAdministrationGUI.php(250): ilCtrl->forwardCommand(Object(ilObjSystemFolderGUI)) ILIAS-eLearning#12 ILIAS_PATH/Services/UICore/classes/class.ilCtrl.php(210): ilAdministrationGUI->executeCommand() ILIAS-eLearning#13 ILIAS_PATH/Services/UICore/classes/class.ilCtrl.php(175): ilCtrl->forwardCommand(Object(ilAdministrationGUI)) ILIAS-eLearning#14 ILIAS_PATH/ilias.php(20): ilCtrl->callBaseClass() ILIAS-eLearning#15 {main}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Leider gibt es beim Speichern von illegalen Werten auch in 5.13.12+ noch ein Problem: zwar wird die erste Speicherung verhindert, bei einem wiederholten Submit gehen die Daten aber wieder verloren, vgl. folgendes Video:
ilias-save-error.mov.zip
Dieser PR behebt das Problem, indem der
save_errorder vorherigen Speicherung (vgl.ilTestOutputGUI::saveQuestionSolution) überprüft wird; gab es einen solchen error (z.B. wegen. einer fehlgeschlagenen Validierung inassClozeTest::validateSolutionSubmit) wird davon ausgegangen, dass die Frage im Zustand "verändert" ist, also auf jeden Fall nochmal gespeichert werden muss. Der momentane Fehler liegt - anders herum betrachtet - daran, dass die Frage trotz der Änderungen, die nicht validiert und damit gespeichert wurden, in den Zustand "unverändert" geht.