Conversation
|
| Section | From | To | Bytes | |
|---|---|---|---|---|
| 📈 | .data |
91.70% | 97.66% | +56 |
| ✅ | .rodata |
99.84% | 100.00% | +/-0 |
| 📈 | .text |
93.21% | 94.27% | +18 |
| Function | From | To | Bytes | |
|---|---|---|---|---|
| ❔ | zCombo_Setup() |
94.64% | 94.70% | +/-0 |
| 📈 | zCombo_Update(float) |
94.59% | 96.82% | +18 |
JoshSanch
requested changes
Dec 26, 2025
src/SB/Game/zCombo.cpp
Outdated
|
|
||
| /* .sbss */ | ||
| static widget_chunk* comboHUD; | ||
| widget_chunk* comboHUD; |
Collaborator
There was a problem hiding this comment.
If this is global, it should also be extern'd inside of the zCombo.h header so that it is properly exported and accessible from other files.
Contributor
Author
There was a problem hiding this comment.
That doesn't work for some reason, left a comment instead for now.
|
| Section | From | To | Bytes | |
|---|---|---|---|---|
| 📈 | .data |
91.70% | 97.66% | +56 |
| ✅ | .rodata |
99.84% | 100.00% | +/-0 |
| 📈 | .text |
93.21% | 94.27% | +18 |
| Function | From | To | Bytes | |
|---|---|---|---|---|
| ❔ | zCombo_Setup() |
94.64% | 94.70% | +/-0 |
| 📈 | zCombo_Update(float) |
94.59% | 96.82% | +18 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems equivalent to me, with some float/sda issues left and a switch statement's jump table needing to be matched, but leaving marked as NonMatching for now.