Fix phase-1/phase-2 validation gap in RESP decoder#4
Merged
Conversation
Move semantic validation (boolean bytes, doubles, big numbers, verbatim format) into frame_len/count_value so decode errors are returned before split_to consumes input bytes. Adds tests for invalid boolean wire form and buffer preservation on all semantic error paths. Co-authored-by: Jared Lunde <jared.lunde@gmail.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The decoder used a two-phase design where
frame_lenvalidated structure andbuild_valueperformed semantic checks. When phase 2 failed,split_tohad already removed bytes from the input buffer, causing silent data loss on malformed frames.This moves semantic validation into phase 1 (
count_value/frame_len) for:#t/#f),)()=colon separator and minimum length)Decode errors on these types now return before any bytes are consumed.
Tests
boolean_invalid_byteunit testsemantic_error_leaves_buffer_unconsumedintegration test covering double, big number, verbatim, and boolean semantic errors