feat(medici): TAN-2598: Added discharge_date parameter to Medici API (hotfix 2.45)#9262
Merged
rohan-bes merged 5 commits intorelease/2.45from Mar 11, 2026
Merged
Conversation
Contributor
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a discharge_date parameter to the Medici API, allowing for more refined filtering of encounters. The changes include updates to the route handler to process this new parameter and apply it to the database query, along with comprehensive new test cases to validate the filtering logic with various date prefixes. The implementation is solid, but I have one suggestion to improve the readability and maintainability of the SQL query.
rohan-bes
changed the title
dannash100
reviewed
Mar 3, 2026
| discharge_date_le: null, | ||
| discharge_date_eq: null, | ||
| }; | ||
| const dischargeDateParams = [].concat(dischargeDateParam ?? []).filter(Boolean); |
Contributor
There was a problem hiding this comment.
I dont think this would ever have anything that would be falsey so could skip the filter 🤔
Collaborator
Author
There was a problem hiding this comment.
Yeah does seem a bit weird, AI added it, I'll remove it
dannash100
approved these changes
Mar 3, 2026
Contributor
dannash100
left a comment
dannash100
left a comment
There was a problem hiding this comment.
Looks good, just a small comment
rohan-bes
force-pushed
the
feat/tan-2598-medici-api-discharge-date
branch
from
d166a4f to
4260e88
Compare
rohan-bes
changed the title
rohan-bes
force-pushed
the
feat/tan-2598-medici-api-discharge-date
branch
from
4260e88 to
a5d333f
Compare
|
Android builds 📱
|
🍹
|
rohan-bes
force-pushed
the
feat/tan-2598-medici-api-discharge-date
branch
from
a5d333f to
7a14513
Compare
rohan-bes
changed the title
🍹
|
passcod
approved these changes
Mar 11, 2026
rohan-bes
added a commit
that referenced
this pull request
Mar 18, 2026
…(hotfix 2.45) (#9262) * feat(medici): TAN-2598: Added discharge_date parameter to Medici API * fix(migrations): TAMOC-398: Fixed MediciReport test * feat(medici): TAN-2598: Added test for using local timezone * tweak(cd): use tailscale OIDC (#9039) * feat(medici): TAN-2598: Removed unneeded filter --------- Co-authored-by: Rohan Port <rohan@bes.au> Co-authored-by: Félix Saparelli <felix@bes.au>
rohan-bes
added a commit
that referenced
this pull request
Mar 18, 2026
…(hotfix 2.45) (#9262) * feat(medici): TAN-2598: Added discharge_date parameter to Medici API * fix(migrations): TAMOC-398: Fixed MediciReport test * feat(medici): TAN-2598: Added test for using local timezone * tweak(cd): use tailscale OIDC (#9039) * feat(medici): TAN-2598: Removed unneeded filter --------- Co-authored-by: Rohan Port <rohan@bes.au> Co-authored-by: Félix Saparelli <felix@bes.au>
rohan-bes
added a commit
that referenced
this pull request
Mar 18, 2026
…(hotfix 2.45) (#9262) * feat(medici): TAN-2598: Added discharge_date parameter to Medici API * fix(migrations): TAMOC-398: Fixed MediciReport test * feat(medici): TAN-2598: Added test for using local timezone * tweak(cd): use tailscale OIDC (#9039) * feat(medici): TAN-2598: Removed unneeded filter --------- Co-authored-by: Rohan Port <rohan@bes.au> Co-authored-by: Félix Saparelli <felix@bes.au>
rohan-bes
added a commit
that referenced
this pull request
Mar 18, 2026
…(hotfix 2.45) (#9262) * feat(medici): TAN-2598: Added discharge_date parameter to Medici API * fix(migrations): TAMOC-398: Fixed MediciReport test * feat(medici): TAN-2598: Added test for using local timezone * tweak(cd): use tailscale OIDC (#9039) * feat(medici): TAN-2598: Removed unneeded filter --------- Co-authored-by: Rohan Port <rohan@bes.au> Co-authored-by: Félix Saparelli <felix@bes.au>
rohan-bes
added a commit
that referenced
this pull request
Mar 18, 2026
…(hotfix 2.45) (#9262) * feat(medici): TAN-2598: Added discharge_date parameter to Medici API * fix(migrations): TAMOC-398: Fixed MediciReport test * feat(medici): TAN-2598: Added test for using local timezone * tweak(cd): use tailscale OIDC (#9039) * feat(medici): TAN-2598: Removed unneeded filter --------- Co-authored-by: Rohan Port <rohan@bes.au> Co-authored-by: Félix Saparelli <felix@bes.au>
rohan-bes
added a commit
that referenced
this pull request
Mar 18, 2026
…(hotfix 2.45) (#9262) * feat(medici): TAN-2598: Added discharge_date parameter to Medici API * fix(migrations): TAMOC-398: Fixed MediciReport test * feat(medici): TAN-2598: Added test for using local timezone * tweak(cd): use tailscale OIDC (#9039) * feat(medici): TAN-2598: Removed unneeded filter --------- Co-authored-by: Rohan Port <rohan@bes.au> Co-authored-by: Félix Saparelli <felix@bes.au>
rohan-bes
added a commit
that referenced
this pull request
Mar 18, 2026
…(hotfix 2.45) (#9262) * feat(medici): TAN-2598: Added discharge_date parameter to Medici API * fix(migrations): TAMOC-398: Fixed MediciReport test * feat(medici): TAN-2598: Added test for using local timezone * tweak(cd): use tailscale OIDC (#9039) * feat(medici): TAN-2598: Removed unneeded filter --------- Co-authored-by: Rohan Port <rohan@bes.au> Co-authored-by: Félix Saparelli <felix@bes.au>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Added this parameter so that Medici can avoid fetching historical encounters when common reference data get updated.
Deploys
Tests
Review Hero
Remember to...