feat(admin): COOL-52: Admin impersonate role#9202
Merged
dannash100 merged 35 commits intomainfrom Apr 21, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Contributor
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
Author
|
bugbot run |
Contributor
Author
|
bugbot run |
Contributor
Author
|
Code scanning issue is hitting existing code |
dannash100
changed the title
|
Android builds 📱
|
🍹
|
rohan-bes
approved these changes
Mar 2, 2026
Collaborator
rohan-bes
left a comment
rohan-bes
left a comment
There was a problem hiding this comment.
This looks well implemented, nice. Couple comments but nothing blocking.
…sential/tamanu into feat/impersonate-a-role
| } catch { | ||
| return null; | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Manual JWT decode duplicates existing jose utility
Low Severity
getImpersonateRoleIdFromToken manually splits and decodes the JWT payload using atob with base64url-to-base64 replacements, duplicating the logic already available in the jose library (decodeJwt) which is a dependency of @tamanu/api-client and supports browser environments. The base class already uses decodeJwt from jose in its login method to decode JWT claims. Using the existing utility avoids subtle encoding edge cases (e.g., missing base64 padding) and reduces duplication.
Reviewed by Cursor Bugbot for commit c7c9b9a. Configure here.
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit aada6d3. Configure here.
| [STOP_IMPERSONATION]: action => ({ | ||
| impersonatingRole: null, | ||
| ability: action.ability, | ||
| }), |
Contributor
There was a problem hiding this comment.
Redux token state becomes stale after impersonation
Medium Severity
The IMPERSONATE_ROLE and STOP_IMPERSONATION Redux actions update ability and impersonatingRole but never update token. Meanwhile, startImpersonation and stopImpersonation thunks call api.setToken(token) which writes the new JWT to localStorage and the API client. This creates a split-brain state: state.auth.token holds the pre-impersonation JWT while localStorage and the API client hold the post-impersonation JWT. Any code reading from state.auth.token — such as the bootstrap code in index.js — would see a stale value.
Additional Locations (2)
Reviewed by Cursor Bugbot for commit aada6d3. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
⌘ + clickavatarimpersonate.mov
Server (
facility-server)POST /admin/impersonate— admin-only endpoint that accepts aroleId, mints a new JWT with the impersonated role embedded, and returns the token + recalculated permissions for that roleRedux store (
web/store/auth.js)startImpersonation(role)— calls the server endpoint, swaps the JWT viaapi.setToken(), persists the impersonated role + permissions to localStorage, rebuilds the CASL ability for the impersonated role, dispatchesIMPERSONATE_ROLEstopImpersonation()— same endpoint withroleId: null, restores original token/permissions/ability, dispatchesSTOP_IMPERSONATIONAuth context (
web/contexts/Auth.jsx)impersonatingRoleandabilityfrom Redux and exposes them app-wide viaAuthContextability, so the entire UI reflects the impersonated role's accessUI (
web/components/Sidebar/)HiddenSyncAvatar— meta-click (Cmd/Ctrl+click) on the avatar opens the popover (admin only), visual indicator when impersonatingDeploys
Tests
Review Hero
Remember to...