feat(integrations): PHX-297: Send transactions to open mSupply API#9195
Merged
NavarroEmilioLuis merged 46 commits intomainfrom Mar 18, 2026
Merged
Conversation
Contributor
Summary of ChangesHello @NavarroEmilioLuis, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request establishes a new, automated integration with the Open mSupply API, designed to streamline the transfer of dispensed medication data from the system. It introduces a robust scheduled process that handles authentication, batches data for efficient transmission, and provides detailed logging for monitoring and troubleshooting. The integration is highly configurable through facility-specific settings, ensuring flexibility and control over how medication data is synchronized with external mSupply instances. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new integration to send medication dispense transactions to an open mSupply API. The changes follow a good pattern, including a database migration for logging, a new Sequelize model, a scheduled task for processing, comprehensive tests, and the necessary configuration and settings schemas. My review focuses on improving the robustness of the data processing. I've identified a potential correctness issue with the batch pagination logic that could lead to data inconsistency under concurrent operations, and a minor issue with logging that might discard useful debugging information. Overall, this is a solid implementation of the new feature.
NavarroEmilioLuis
changed the title
rohan-bes
approved these changes
Feb 23, 2026
Collaborator
rohan-bes
left a comment
rohan-bes
left a comment
There was a problem hiding this comment.
Have a few comments and optional requests for rename/refactor, but nothing blocking. Looks solid, and with all things integrations there's usually a bit of tweaking once you start actually integrating so best to get to that point sooner rather than later :)
| } | ||
|
|
||
| // Designed to post dispensed medications from pharmacy to an Open mSupply instance | ||
| export class mSupplyMedIntegrationProcessor extends ScheduledTask { |
Collaborator
There was a problem hiding this comment.
I know you're following a bit of a convention here with the DHIS2IntegrationProcessor but tbh I don't love that naming convention as its not very clear about what the task actually does. Thoughts on something like MSupplyMedicationStockUpdater?
Contributor
Author
There was a problem hiding this comment.
I'm fine either way, though I'm unsure what we will have to do with the new endpoint update. I'd rather leave it generic + comment
| const batchCount = Math.ceil(toProcess / batchSize); | ||
|
|
||
| for (let i = 0; i < batchCount; i++) { | ||
| const medications = await this.models.MedicationDispense.findAll({ |
Collaborator
There was a problem hiding this comment.
I could have seen us wanting to group the dispenses by medication code, so that we just send the sum of all dispenses per medication. Was that considered? I guess we get a bit more granularity this way for reporting and can better handle when mSupply stock runs out.
Contributor
Author
There was a problem hiding this comment.
Considered for a second maybe, but I think it's getting ahead. Also, would not work with the current cursor approach as we would have to save a log per group code or something in the likes.
PS: I'd also leave this for later if anything, considering granularity + simplicity + deadline!
Co-authored-by: Rohan Port <59544282+rohan-bes@users.noreply.github.com>
|
Android builds 📱
|
🍹
|
Comment on lines
+125
to
+137
| "mSupplyMedIntegrationProcessor": { | ||
| "enabled": false, | ||
| "schedule": "0 2 * * *", | ||
| "batchSize": 100, | ||
| "batchSleepAsyncDurationInMilliseconds": 50 | ||
| }, | ||
| }, | ||
| "integrations": { | ||
| "mSupplyMed": { | ||
| "enabled": false, | ||
| "username": "", | ||
| "password": "" | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Deployment team, this is the change, new integration and schedule for the facility server
Harnesh787
approved these changes
Mar 18, 2026
NavarroEmilioLuis
deleted the
feature/phx-297-send-transactions-to-open-msupply-api
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Follows a similar pattern to the DHIS integration. More information on Linear cause there are lots of details here. Note that one third of the LOC is the test file, the other third is probably boilerplate (migration, model, config, dbt) and the rest is the actual task file to send the transactions.
Deploys