feat(deathData): PHX-272: Create FSM death certificate#9165
Merged
NavarroEmilioLuis merged 44 commits intomainfrom Mar 19, 2026
Merged
feat(deathData): PHX-272: Create FSM death certificate#9165NavarroEmilioLuis merged 44 commits intomainfrom
NavarroEmilioLuis merged 44 commits intomainfrom
Conversation
Contributor
Summary of ChangesHello @NavarroEmilioLuis, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request implements the functionality for generating Federated States of Micronesia (FSM) death certificates. It involves significant changes across the application stack, from database schema modifications to accommodate new FSM-specific data points, to updates in the API for handling this data, and a complete overhaul of the death form's optional sections to support FSM-specific questions and a new FSM-styled printout. The changes ensure that the system can accurately capture and present death information according to FSM requirements, activated by a feature flag. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new FSM death certificate, including a new database field, model updates, API changes, a new printout component, and a significant refactoring of the death form to support different certificate styles. The changes are well-structured, especially the refactoring of the DeathForm into smaller, conditional pages.
I've found one issue in the new FSMDeathCertificatePrintout.jsx component where incorrect data is being displayed for the manner of death. My review includes a specific comment with a suggestion to fix this.
NavarroEmilioLuis
force-pushed
the
feature/phx-272-create-new-death-certificate-for-fsm
branch
from
86d3357 to
eea684d
Compare
NavarroEmilioLuis
changed the base branch from
main-base-2026-02-11
to
feature/phx-271-update-birth-certificate
Contributor
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
This is the final PR Bugbot will review for you during this billing cycle
Your free Bugbot reviews will reset on March 28
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
dannash100
reviewed
Feb 17, 2026
dannash100
reviewed
Feb 17, 2026
| return entry ? entry.label : ''; | ||
| }; | ||
|
|
||
| const FSM_DATE_FORMAT = 'MM/dd/yyyy'; |
Contributor
There was a problem hiding this comment.
Do we want to fix date format here? Or just use formatShort?
Contributor
Author
There was a problem hiding this comment.
FSM wants this specific day format, notice it's months first!
dannash100
reviewed
Feb 17, 2026
dannash100
requested changes
Feb 17, 2026
Contributor
dannash100
left a comment
dannash100
left a comment
There was a problem hiding this comment.
Just that comment re that promise all, otherwise looking good
Base automatically changed from
feature/phx-271-update-birth-certificate
to
main
February 23, 2026 15:07
…erence data name values Co-authored-by: Cursor Bugbot <bugbot@cursor.com>'
NavarroEmilioLuis
force-pushed
the
feature/phx-272-create-new-death-certificate-for-fsm
branch
from
6995ca4 to
fa8d470
Compare
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
|
Android builds 📱
|
🍹
|
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
NavarroEmilioLuis
deleted the
feature/phx-272-create-new-death-certificate-for-fsm
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Alright, some changes!
Deploys
Note
Medium Risk
Adds a new JSONB
extra_datacolumn and threads it through API + form + PDF generation; mistakes could silently drop or mis-shape certificate data. Also includes unresolved merge-conflict markers inFSMBirthNotificationCertificate.jsx, which is a release-blocking build risk.Overview
Adds FSM-specific death certificate support behind the
fsmCrvsCertificates.enableFSMStylesetting, including a newFSMDeathCertificatePrintout(2-page, landscape) and wiring the print modal to passprintedBy.Extends death data persistence with a new JSONB
patient_death_data.extra_datacolumn (PatientDeathData.extraData), updates the patient death API (GET/POST) and validation schema to accept/returnextraData, and addsFSM_FIELDSconstants plus form changes to collect FSM-only fields and nest them intoextraDataon submit.Refactors the death form into reusable optional-page components (
DeathFormOptionalPages.jsx), adds an FSM-only questions page (including hierarchy-based place-of-death selectors), and updatesHierarchyFieldsto optionally render without its container.Includes an unrelated change that introduces merge conflict markers in
FSMBirthNotificationCertificate.jsxthat must be resolved.Written by Cursor Bugbot for commit eea684d. Configure here.