feat(fhir): NASS-1883: Allow SENAITE to specify a custom reference range for a lab test#9126
Open
feat(fhir): NASS-1883: Allow SENAITE to specify a custom reference range for a lab test#9126
Conversation
Contributor
Summary of ChangesHello @rohan-bes, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enables the system to handle more granular lab test reference ranges by allowing individual lab tests to store and display their own specific reference range values. This is particularly useful for integrating with external systems like SENAITE, which can provide more accurate and context-specific ranges. The changes involve updating the database schema, enhancing the FHIR Observation processing logic to capture these ranges, and adjusting the user interface to correctly present them. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
rohan-bes
commented
Feb 6, 2026
Comment on lines
+4
to
+11
| await query.addColumn('lab_tests', 'reference_range_min', { | ||
| type: DataTypes.DOUBLE, | ||
| allowNull: true, | ||
| }); | ||
| await query.addColumn('lab_tests', 'reference_range_max', { | ||
| type: DataTypes.DOUBLE, | ||
| allowNull: true, | ||
| }); |
Collaborator
Author
There was a problem hiding this comment.
No need to rebuild the lookup table if just adding new columns that can be null
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request effectively implements the feature to allow custom reference ranges for lab tests, overriding the defaults from LabTestType. The changes are well-structured, spanning from the database migration and model updates to the backend processing logic and frontend display. The inclusion of a new test case for the Observation resource ensures the new logic is covered.
I have one suggestion to improve code conciseness in FhirObservation.ts. Overall, great work!
Comment on lines
+178
to
+185
| const lowValue = | ||
| first?.low != null && typeof first.low === 'object' && 'value' in first.low | ||
| ? first.low.value | ||
| : null; | ||
| const highValue = | ||
| first?.high != null && typeof first.high === 'object' && 'value' in first.high | ||
| ? first.high.value | ||
| : null; |
Contributor
There was a problem hiding this comment.
The logic to extract lowValue and highValue is a bit verbose. Since the data is validated against a yup schema before this method is called, we can be confident about the shape of first.low and first.high. You can simplify this using optional chaining and the nullish coalescing operator, which would make the code more concise and readable.
const lowValue = first?.low?.value ?? null;
const highValue = first?.high?.value ?? null;
|
Android builds 📱
|
🍹
|
added 4 commits
February 10, 2026 14:34
…nge for a lab test
rohan-bes
force-pushed
the
feat/nass-1883-senaite-custom-reference-range
branch
from
884b149 to
0b485a6
Compare
tcodling
approved these changes
Feb 12, 2026
Contributor
tcodling
left a comment
tcodling
left a comment
There was a problem hiding this comment.
Lgtm!
Honestly the only thing for me is that the term referenceRange doesn't seem super clear to someone unfamiliar with this feature/fhir 🤔 Id maybe add some more comments around logic using this and how it relates to integrations if this was me but thats probably me being a bit overly cautious
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
We're now allowing individual LabTests to have a reference range that overrides the default defined in the LabTestType. This range will only be set if we're receiving lab results from SENAITE, which provides more accurate ranges than the ones in Tamanu.
Deploys
Tests
Remember to...