feat(fhir): NASS-1871: Allow SENAITE to create reflex tests via the FHIR API#9119
Open
feat(fhir): NASS-1871: Allow SENAITE to create reflex tests via the FHIR API#9119
Conversation
Contributor
Summary of ChangesHello @rohan-bes, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the FHIR API's capability to process laboratory observations by introducing support for 'reflex tests'. Previously, the system would reject observations if their codes did not match pre-existing tests in a LabRequest. Now, it intelligently creates new lab tests on the fly for such observations, streamlining the workflow for dynamic lab testing scenarios and improving data capture flexibility. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a valuable feature to handle reflex tests by creating new LabTest records for incoming FHIR Observations that don't correspond to existing tests in a LabRequest. The implementation is straightforward and the accompanying tests cover the new success path. I've identified a bug where an incorrect date function is used for completedDate, and I have a few suggestions to improve error messaging and test coverage for the new logic.
| '$labTestType.id$': newTestType.id, | ||
| }, | ||
| }); | ||
| expect(labTest.result).toBe(result); |
Contributor
There was a problem hiding this comment.
Since the logic for updating a LabTest now also sets the completedDate, it would be beneficial to add an assertion here to ensure it's being set correctly. This will improve the test coverage for the new functionality.
expect(labTest.result).toBe(result);
expect(labTest.completedDate).not.toBeNull();
rohan-bes
force-pushed
the
feat/nass-1871-senaite-reflex-tests
branch
from
5be8d68 to
4a59eb1
Compare
|
Android builds 📱
|
🍹
|
rohan-bes
force-pushed
the
feat/nass-1871-senaite-reflex-tests
branch
from
4a59eb1 to
8eb4840
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Pretty simple change here to instead of rejecting an Observation if it's code isn't in the LabRequest's tests already, just create a new test.
Deploys
Tests
Remember to...