feat: skip persistent schemas that don't exist on source during migration#8
Merged
feat: skip persistent schemas that don't exist on source during migration#8
Conversation
…tion When the persistent_schemas list includes a schema that was never created on the source restore, the operator now queries the source database to filter the list before launching the migration job. Missing schemas are logged at warn level and silently skipped. If none of the listed schemas exist on the source, migration is skipped entirely and the switchover proceeds immediately.
![review-hero[bot]](https://avatars.githubusercontent.com/in/2896273?s=60&v=4){kind=small}
|
🦸 Review Hero Summary |
|
🦸 Review Hero Auto-Fix Skipped 4 comments (replied on each thread). |
|
🦸 Review Hero Auto-Fix |
passcod
force-pushed
the
feat/skip-missing-source-schemas
branch
from
099185c to
1918d73
Compare
The in-progress restore check at line 898 was running before the consecutive failures check, setting the phase back to Restoring and returning early. This prevented the suspension block from correcting the phase, causing it to stay stuck at Restoring even while suspended.
passcod
force-pushed
the
feat/skip-missing-source-schemas
branch
from
1918d73 to
918f1d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the persistent_schemas list includes a schema that was never created on the source restore, the operator now queries the source database to filter the list before launching the migration job. Missing schemas are logged at warn level and silently skipped.
If none of the listed schemas exist on the source, migration is skipped entirely and the switchover proceeds immediately.
🦸 Review Hero